<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16671">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16671#inline-91300">View Inline</a><span style="color: #4b4d51; font-weight: bold;">embeddedimagedata.cpp:204</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">TagLib</span><span style="color: #aa2211">::</span><span class="n">ByteVector</span> <span class="n">pictureData</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">itApe</span><span class="p">).</span><span class="n">second</span><span class="p">.</span><span class="n">binaryData</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">int</span> <span class="n">dataPosition</span> <span style="color: #aa2211">=</span> <span class="n">pictureData</span><span class="p">.</span><span class="n">find</span><span class="p">(</span><span style="color: #766510">'\0'</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span style="color: #004012">QByteArray</span><span class="p">(</span><span class="n">pictureData</span><span class="p">.</span><span class="n">data</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">dataPosition</span><span class="p">,</span> <span class="n">pictureData</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">dataPosition</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I know you have only moved this code here ...</p>

<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">TagLib::ByteVector::find</tt> returns <tt style="background: #ebebeb; font-size: 13px;">-1</tt> on not found, and we add 1, so this is safe here. But maybe we should return <tt style="background: #ebebeb; font-size: 13px;">QByteArray()</tt> instead?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16671">https://phabricator.kde.org/D16671</a></div></div><br /><div><strong>To: </strong>astippich, mgallien, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>