D16554: move supported mimetypes to static string list

Alexander Stippich noreply at phabricator.kde.org
Thu Nov 1 16:16:54 GMT 2018


astippich added inline comments.

INLINE COMMENTS

> bruns wrote in epubextractor.cpp:44
> The idea behind using anonymous namespaces is to neither "pollute" the class namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, see `fetchMetadata`.

All the stringlists are currently implemented as a private static member of the class... would you like to change that to a local static variable?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/6aa95651/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list