D16554: move supported mimetypes to static string list

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Nov 1 13:28:42 GMT 2018


bruns added inline comments.

INLINE COMMENTS

> epubextractor.cpp:44
>  {
> +const QStringList EPubExtractor::mMimetypes = {
> +    QStringLiteral("application/epub+zip"),

The idea behind using anonymous namespaces is to neither "pollute" the class namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, see `fetchMetadata`.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/ec373e38/attachment.html>


More information about the Kde-frameworks-devel mailing list