D16554: move supported mimetypes to static string list

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Nov 1 18:21:54 GMT 2018


bruns added inline comments.

INLINE COMMENTS

> astippich wrote in epubextractor.cpp:44
> All the stringlists are currently implemented as a private static member of the class... would you like to change that to a local static variable?

I consider this cleaner, yes.
We don't expose static helper functions, either.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/f6423cae/attachment.html>


More information about the Kde-frameworks-devel mailing list