D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

[Christoph Feck]

cfeck added a comment.


  I like the refactoring, much easier to read.
  
  I have to agree with Nathan that the special casing for the alpha is unneeded. For users having a black selection color, it wouldn't tint at all.
  
  We deliberately used a small blending value (0.2) to make sure the resulting color is not too different from the standard window background color.

INLINE COMMENTS

> kmessagewidget.cpp:266
> +            value.setRgb(rgb.at(0).toInt(), rgb.at(1).toInt(), rgb.at(2).toInt());
> +        } else if (rgb.size() >= 3) {
> +            value.setRgb(rgb.at(0).toInt(), rgb.at(1).toInt(), rgb.at(2).toInt(), rgb.at(3).toInt());

`>= 4`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180628/84d8d57d/attachment.html>