<table><tr><td style="">cfeck added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13777">View Revision</a></tr></table><br /><div><div><p>I like the refactoring, much easier to read.</p>

<p>I have to agree with Nathan that the special casing for the alpha is unneeded. For users having a black selection color, it wouldn't tint at all.</p>

<p>We deliberately used a small blending value (0.2) to make sure the resulting color is not too different from the standard window background color.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13777#inline-72531">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmessagewidget.cpp:266</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">value</span><span class="p">.</span><span class="n">setRgb</span><span class="p">(</span><span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span class="n">toInt</span><span class="p">(),</span> <span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">).</span><span class="n">toInt</span><span class="p">(),</span> <span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">rgb</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">3</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">value</span><span class="p">.</span><span class="n">setRgb</span><span class="p">(</span><span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span class="n">toInt</span><span class="p">(),</span> <span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">).</span><span class="n">toInt</span><span class="p">(),</span> <span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">).</span><span class="n">toInt</span><span class="p">(),</span> <span class="n">rgb</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">3</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">>= 4</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 KWidgetsAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13777">https://phabricator.kde.org/D13777</a></div></div><br /><div><strong>To: </strong>rjvbb, ngraham, Frameworks<br /><strong>Cc: </strong>cfeck, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>