D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> global.cpp:58
>  
> -    const int precision = (unit == 0) ? 0 : 1; // unit == 0 -> Bytes, no rounding
> -    return dialectUnits.at(unit).arg(QLocale().toString(size, 'f', precision));
> +    return KFormat().formatByteSize(fileSize, -1, dialect);
>  }

Should this -1 be 1? Looking at the kformat code it'll use that unless unit is 0 so the old code would be using 1 and the new one -1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13549

To: pino, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180625/3f7845ff/attachment.html>