D13549: Switch KIO::convertSize() to KFormat::formatByteSize()
Pino Toscano
noreply at phabricator.kde.org
Mon Jun 25 18:43:43 UTC 2018
pino added inline comments.
INLINE COMMENTS
> aacid wrote in global.cpp:44
> Am i reading the code wrong or are we doing the readEntry twice? (i know the old code did the same)
>
> Do you understand why?
> Am i reading the code wrong or are we doing the readEntry twice? (i know the old code did the same)
Apparently so.
> Do you understand why?
No, that is why I chose to not touch at all, keeping the behaviour unchanged (it is not related to this patch, anyway).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13549
To: pino, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180625/08aaa99c/attachment.html>
More information about the Kde-frameworks-devel
mailing list