D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

Pino Toscano noreply at phabricator.kde.org
Tue Jun 26 05:52:33 UTC 2018


pino marked an inline comment as done.
pino added inline comments.

INLINE COMMENTS

> aacid wrote in global.cpp:58
> Should this -1 be 1? Looking at the kformat code it'll use that unless unit is 0 so the old code would be using 1 and the new one -1

Indeed, 1 is the right value, and `KFormat` does the right thing when the unit is byte.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13549

To: pino, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180626/aa31bd6e/attachment.html>


More information about the Kde-frameworks-devel mailing list