D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh marked 2 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadataprovider.cpp:141
> Why not? `insertEditableData()` just sets some defaults, how is it related to `files`?

I've been thinking about this...

We already have guards against files.isEmpty() in

  355    if (!urls.isEmpty()) {

and

  373  } else if (items.size() == 1)  {

Unless I got something wrong files cannot be empty at this point.
Maybe it is wiser to clarify this with

  Q_ASSERT(!files.isEmpty)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/7a0de532/attachment.html>