D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> michaelh wrote in filemetadataprovider.cpp:141
> I've been thinking about this...
> 
> We already have guards against files.isEmpty() in
> 
>   355    if (!urls.isEmpty()) {
> 
> and
> 
>   373  } else if (items.size() == 1)  {
> 
> Unless I got something wrong files cannot be empty at this point.
> Maybe it is wiser to clarify this with
> 
>   Q_ASSERT(!files.isEmpty)

Yeah I think you got it right. `fetchJob->data()` should not be empty as long as we passed a non-empty list of urls to `FileFetchJob`.

Which means an assert about this is a good idea, indeed.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/d62cab51/attachment.html>