D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadataprovider.cpp:137
> +    
> +    if (files.size() == 0) {
> +        emit loadingFinished();

`files.isEmpty()`

> michaelh wrote in filemetadataprovider.cpp:141
> We can leave early here, I think. 
> Without a file
> 
>   149  insertEditableData() 
> 
> does not make much sense.

Why not? `insertEditableData()` just sets some defaults, how is it related to `files`?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/ffac8ea1/attachment.html>