D9286: don't multiply svg sizes by devicepixelratio

David Edmundson noreply at phabricator.kde.org
Tue Jan 23 11:57:53 UTC 2018


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I'm 100% convinced Plasma needs to multiply it as it does everything in device pixels.
  
  However:
  
  void FrameSvgItem::updateDevicePixelRatio()
  
    m_frameSvg->setScaleFactor(qMax<qreal>(1.0, floor(Units::instance().devicePixelRatio())));
  
  this changes elementSize
  
  So with this code and that we're doing it twice. You're right one of them should die.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/dropdevicepixelratiowq!

REVISION DETAIL
  https://phabricator.kde.org/D9286

To: mart, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180123/3f1030d9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list