D9286: don't multiply svg sizes by devicepixelratio

[David Edmundson]

davidedmundson added a comment.


  I handle scaling everyewhere except for Plasma which does it's own thing.
  
  ----
  
  I'm not convinced by this patch:
  
  If this was Qt's devicePixelRatio this would definitely 100% make sense as there we write all UI code in logical sizes.
  
  But in Plasma it's up to the developer to convert everything from logical pixles to devicePixels themselves, so it does makes sense to multiply surely?
  
  On wayland we have both systems going at once.
  Which sounds super broken, but it just about works because Units.devicePixelRatio is (implicitly) divided through by Qt's devicePixelRatio.
  
  Units.devicePixelRatio should be exactly 1, because (unless explicitly overridden) our logical DPI is set to 96.    (96/96 =1)
  
  So this patch shouldn't be affecting anything?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9286

To: mart, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180117/2622c859/attachment.html>