D10405: Don't proceed in runCommandInternal if the executable doesn't exit

Eike Hein noreply at phabricator.kde.org
Mon Feb 12 11:53:15 UTC 2018


hein added a comment.


  @dfaure I don't see how the virtual thing is going to work - there's numerous static affected codepaths so there's no 'this' to pass down to call the non-static error handler on.
  
  I could add a new "silent" RunFlag and pass that around to quiet the message box altogether, but this would mean zero error handling. I'm unhappy about that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180212/af7c2e3f/attachment.html>


More information about the Kde-frameworks-devel mailing list