D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  Yes. Well, you can't add new virtual methods, but these two already exist:
  
    virtual void handleInitError(int kioErrorCode, const QString &errorMsg);
    virtual void handleError(KJob *job);
  
  I think you should be able to (ab)use the first one for this purpose.
  
  (It's called "init" as opposed to "when running a kjob, later", with the assumption that these are the only two cases that can happen but it really means "when we don't have a kjob"; should have been called something more generic, I see now)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180212/4655cec3/attachment.html>