D10405: Don't proceed in runCommandInternal if the executable doesn't exit
David Faure
noreply at phabricator.kde.org
Mon Feb 12 12:08:16 UTC 2018
dfaure added a comment.
The statics can be refactored, if they're internal ;)
What's more troublesome is the KRun instance might have gone away by the time KProcessRunner ::slotProcessExited is called, though (which is why it's done in a different class).
So maybe what's needed is rather some interface, like defaultJobUiDelegateExtension()->requestMessageBox().
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10405
To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180212/5c3634b5/attachment.html>
More information about the Kde-frameworks-devel
mailing list