D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Albert Astals Cid]

aacid added a comment.


  In D14779#309643 <https://phabricator.kde.org/D14779#309643>, @habacker wrote:
  
  > In D14779#308603 <https://phabricator.kde.org/D14779#308603>, @aacid wrote:
  >
  > > I think that in the test we just need to call
  > >
  > >   bool QCoreApplication::installTranslator(QTranslator *translationFile)
  > >
  > > with the location of the fake translation
  >
  >
  >
  >
  > > and since newest location is tried first it should overwrite the one from the ecm loader.
  >
  > According to http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qcoreapplication.cpp#n1985 new translators are prepended - not overwritten.
  
  
  So exactly what i said, the newly installed translator gets used first
  
  > Not sure if a missing translation in the latest file added would be search in the previous translators.
  
  Why would it be missing?
  
  > To  understand you correctly: You really are thinking about generating  a qm file  from the kcoreaddons lib source with gettext containing real translations  added with lokalize or similar to avoid this issue ?
  
  I am not sure what is "this issue", but what we need to do is just copy the english translation from the tarball to here and make sure it's used when the test is run.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180815/a8d7924e/attachment-0001.html>