D10694: epubextractor: Handle multiple subjects better

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> epubextractor.cpp:85
>  
> -    QString value = fetchMetadata(ePubDoc, EPUB_TITLE);
> +    QString value = fetchMetadataString(ePubDoc, EPUB_TITLE);
>      if (!value.isEmpty()) {

I think we should add each title individually (there may be one per language).

Dito for all other properties, see below.

> epubextractor.cpp:97
> +        result->add(Property::Keywords, values[0]);
> +        result->add(Property::Subject, values[0]);
>      }

This looks a little bit inconsistent - if we have only one value, we add the value to two different Properties, otherwise only Keywords is used.

DublinCore uses subject and keywords synonymously. It //recommends// to use one property entry per keyword.

See Recommendation 5 of http://dublincore.org/documents/dc-xml-guidelines/
and e.g. http://dublincore.org/groups/collections/collection-application-profile/#coldcsubject

I think we should stick with either Subject or Keywords, but not both.

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-subject

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: bruns, astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180419/1fa0eaf1/attachment-0001.html>