<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10694">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10694#inline-62600">View Inline</a><span style="color: #4b4d51; font-weight: bold;">epubextractor.cpp:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QString</span> <span class="n">value</span> <span style="color: #aa2211">=</span> <span class="n">fetchMetadata</span><span class="p">(</span><span class="n">ePubDoc</span><span class="p">,</span> <span class="n">EPUB_TITLE</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">value</span> <span style="color: #aa2211">=</span> <span class="n">fetchMetadata<span class="bright">String</span></span><span class="p">(</span><span class="n">ePubDoc</span><span class="p">,</span> <span class="n">EPUB_TITLE</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">value</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think we should add each title individually (there may be one per language).</p>

<p style="padding: 0; margin: 8px;">Dito for all other properties, see below.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10694#inline-62599">View Inline</a><span style="color: #4b4d51; font-weight: bold;">epubextractor.cpp:97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">result</span><span style="color: #aa2211">-></span><span class="n">add</span><span class="p">(</span><span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">Keywords</span><span class="p">,</span> <span class="n">values</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">result</span><span style="color: #aa2211">-></span><span class="n">add</span><span class="p">(</span><span class="n">Property</span><span style="color: #aa2211">::</span><span class="n">Subject</span><span class="p">,</span> <span class="n">values</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This looks a little bit inconsistent - if we have only one value, we add the value to two different Properties, otherwise only Keywords is used.</p>

<p style="padding: 0; margin: 8px;">DublinCore uses subject and keywords synonymously. It <em>recommends</em> to use one property entry per keyword.</p>

<p style="padding: 0; margin: 8px;">See Recommendation 5 of <a href="http://dublincore.org/documents/dc-xml-guidelines/" class="remarkup-link" target="_blank" rel="noreferrer">http://dublincore.org/documents/dc-xml-guidelines/</a><br />
and e.g. <a href="http://dublincore.org/groups/collections/collection-application-profile/#coldcsubject" class="remarkup-link" target="_blank" rel="noreferrer">http://dublincore.org/groups/collections/collection-application-profile/#coldcsubject</a></p>

<p style="padding: 0; margin: 8px;">I think we should stick with either Subject or Keywords, but not both.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>BRANCH</strong><div><div>multi-subject</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10694">https://phabricator.kde.org/D10694</a></div></div><br /><div><strong>To: </strong>michaelh, mgallien, dfaure<br /><strong>Cc: </strong>bruns, astippich, Frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp<br /></div>