D7645: Add highlighting for QDoc configuration files

Dominik Haumann noreply at phabricator.kde.org
Fri Sep 1 20:10:34 UTC 2017


dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

INLINE COMMENTS

> qdocconf.xml:14
> +            <item>buildversion</item>
> +            <item>Cpp</item>
> +            <item>customFilters</item>

Is the capital c intentional?

> qdocconf.xml:94
> +
> +            <context name="value-context" attribute="Normal Text" lineEndContext="#pop" lineEmptyContext="#pop">
> +                <DetectChar attribute="String" context="string-context" char="""/>

Given lineEndContext is pop, do we need the lineEmptyContext?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7645

To: vkrause, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170901/0cb30715/attachment.html>


More information about the Kde-frameworks-devel mailing list