D7645: Add highlighting for QDoc configuration files

Volker Krause noreply at phabricator.kde.org
Fri Sep 1 20:30:01 UTC 2017


vkrause added inline comments.

INLINE COMMENTS

> dhaumann wrote in qdocconf.xml:14
> Is the capital c intentional?

yep, both according to the qdoc docs and real files

> dhaumann wrote in qdocconf.xml:94
> Given lineEndContext is pop, do we need the lineEmptyContext?

Yes, due to the LineContinue rule. The test case fails in two places without that, line 47 and 57, the empty line preceding those doesn't pop due to the line continuation the line before.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7645

To: vkrause, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170901/735e14c8/attachment.html>


More information about the Kde-frameworks-devel mailing list