<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7645" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7645#inline-31293" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qdocconf.xml:14</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><item></span>buildversion<span style="color: #00702a"></item></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><item></span>Cpp<span style="color: #00702a"></item></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><item></span>customFilters<span style="color: #00702a"></item></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is the capital c intentional?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7645#inline-31294" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qdocconf.xml:94</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><context</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"value-context"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Normal Text"</span> <span style="color: #354bb3">lineEndContext=</span><span style="color: #766510">"#pop"</span> <span style="color: #354bb3">lineEmptyContext=</span><span style="color: #766510">"#pop"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><DetectChar</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"String"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"string-context"</span> <span style="color: #354bb3">char=</span><span style="color: #766510">"""</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Given lineEndContext is pop, do we need the lineEmptyContext?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7645" rel="noreferrer">https://phabricator.kde.org/D7645</a></div></div><br /><div><strong>To: </strong>vkrause, Framework: Syntax Hightlighting, dhaumann<br /><strong>Cc: </strong>dhaumann, Frameworks<br /></div>