D8519: do not make the context menu a Window; do not force raise a window

Martin Koller noreply at phabricator.kde.org
Fri Oct 27 11:25:39 UTC 2017


mkoller created this revision.
mkoller added reviewers: davidedmundson, graesslin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The setParent() call in this patch was changing the window flags from Popup to Window, which leads to show the popup with a window frame when activated via a SysTray DBus call.
  I don't know why setParent() is done here in the first place (could not find the change in git history).
  If setParent() should still be done, at least the window flag must be set back to Popup.
  
  The removal of the force activation is done since according to kwin maintainer it is wrong and must be done by the SysTray itself.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D8519

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: mkoller, davidedmundson, graesslin
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171027/43661fc6/attachment.html>


More information about the Kde-frameworks-devel mailing list