<table><tr><td style="">mkoller created this revision.<br />mkoller added reviewers: davidedmundson, graesslin.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8519" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The setParent() call in this patch was changing the window flags from Popup to Window, which leads to show the popup with a window frame when activated via a SysTray DBus call.<br />
I don't know why setParent() is done here in the first place (could not find the change in git history).<br />
If setParent() should still be done, at least the window flag must be set back to Popup.</p>
<p>The removal of the force activation is done since according to kwin maintainer it is wrong and must be done by the SysTray itself.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8519" rel="noreferrer">https://phabricator.kde.org/D8519</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/kstatusnotifieritem.cpp</div></div></div><br /><div><strong>To: </strong>mkoller, davidedmundson, graesslin<br /><strong>Cc: </strong>Frameworks<br /></div>