D5912: minimize dialog resizes/moves

David Edmundson noreply at phabricator.kde.org
Thu May 18 14:51:47 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> dialog.cpp:864
>          if (d->mainItem) {
>              d->syncToMainItemSize();
>          }

I don't understand your description of the problem.

this call both that resizes and moves.
but if the item hasn't changed yet, it shouldn't actually resize anything.

you're implying it does. Why?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5912

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170518/ff23a4b0/attachment.html>


More information about the Kde-frameworks-devel mailing list