D5912: minimize dialog resizes/moves
Marco Martin
noreply at phabricator.kde.org
Thu May 18 14:10:22 UTC 2017
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
take into account size hints also when adjusting with synctomainitemsize
which sometimes has to be executed right before adjusting from the layout
hints, giving one wrong resize
introduce geometryUpdatesBlocked, which stops the dialog
from syncing which is useful when both visual parent and item
contents gets updated in one go (the tooltip) it is not
yet exported to qml and it shouldn't as is dangerous, but
kicker may make use of it between changing the submenu model and
the visualparent
alternative implementations may be:
- a method that takes both main item and visual parent
- delaying with a timer setGeometry (ouch)
this part can also be left behind for now and see if the rest is good enough
TEST PLAN
no visual glitches visible anymore in wayland when moving the tooltip
in the taskbar, x11 ok too
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/dialogresize
REVISION DETAIL
https://phabricator.kde.org/D5912
AFFECTED FILES
src/declarativeimports/core/tooltip.cpp
src/plasmaquick/dialog.cpp
src/plasmaquick/dialog.h
To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170518/359bf3c9/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list