[Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days of the week

[Michael Pyne]

mpyne added a comment.


  In https://phabricator.kde.org/D4023#76891, @aacid wrote:
  
  > I find the comments misleading (maybe because i'm not english native) but
  >
  >   if (daysTo < -1) {
  >         switch (date.dayOfWeek()) {
  >         case 1:
  >             return tr("Last Monday",    "day in the previous week");
  >         case 2:
  >   
  >
  > Why does it have to be the previous week? If today is Wednesday and the date we're referring to is Monday, daysTo will be -2 and it will still be the current week and not the previous, no?
  >
  > else if (daysTo > 1) {
  >
  >   switch (date.dayOfWeek()) {
  >   case 4:
  >       return tr("Next Thursday",  "day in the week after this");
  >   
  >
  > If today is Monday and the date we're referring to is Thursday, daysTo will be 3 and it's not "the week after this" it's "this week".
  >
  > Or am i understanding something wrong?
  
  
  You're right.  What's a better phrasing? Or, is the context even necessary for translators here?
  
  Maybe something like "the most recent such day before today" and "the next such day after today"?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4023

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mpyne, #frameworks, kde-i18n-doc, aspotashev, aacid
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170113/8da79073/attachment.html>