Review Request 129280: Fix editing autostart items

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129280/#review100415
-----------------------------------------------------------


Ship it!




You could improve performance by using the same QDir object for both calls (exists and canonicalPath), but ok, this isn't really performance-critical code ;)

- David Faure


On Oct. 30, 2016, 10:36 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129280/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2016, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 371194
>     https://bugs.kde.org/show_bug.cgi?id=371194
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QFileInfo.canonicalFilePath() returns an empty string for non-existant directories, which matches any .desktop file path and makes KPropertiesDialog try to save it to the wrong location. Make sure that the dir exists before trying to match it in the .desktop file path.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp b570a85 
> 
> Diff: https://git.reviewboard.kde.org/r/129280/diff/
> 
> 
> Testing
> -------
> 
> Autostart items can be edited and saved again from the systemsettings autostart KCM.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161030/2c94ae84/attachment.html>