Review Request 129280: Fix editing autostart items

Antonio Rojas arojas at archlinux.org
Mon Oct 31 20:37:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129280/
-----------------------------------------------------------

(Updated Oct. 31, 2016, 8:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit af0105c22ec80e411bf226e77f40987464e478d3 by Antonio Rojas to branch master.


Bugs: 371194
    https://bugs.kde.org/show_bug.cgi?id=371194


Repository: kio


Description
-------

QFileInfo.canonicalFilePath() returns an empty string for non-existant directories, which matches any .desktop file path and makes KPropertiesDialog try to save it to the wrong location. Make sure that the dir exists before trying to match it in the .desktop file path.


Diffs
-----

  src/widgets/kpropertiesdialog.cpp b570a85 

Diff: https://git.reviewboard.kde.org/r/129280/diff/


Testing
-------

Autostart items can be edited and saved again from the systemsettings autostart KCM.


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161031/028f26c0/attachment.html>


More information about the Kde-frameworks-devel mailing list