Review Request 129280: Fix editing autostart items

Antonio Rojas arojas at archlinux.org
Sun Oct 30 22:36:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129280/
-----------------------------------------------------------

(Updated Oct. 30, 2016, 10:36 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Check that the dir exists before tying to match it to the path of the .desktop file being edited


Bugs: 371194
    https://bugs.kde.org/show_bug.cgi?id=371194


Repository: kio


Description (updated)
-------

QFileInfo.canonicalFilePath() returns an empty string for non-existant directories, which matches any .desktop file path and makes KPropertiesDialog try to save it to the wrong location. Make sure that the dir exists before trying to match it in the .desktop file path.


Diffs (updated)
-----

  src/widgets/kpropertiesdialog.cpp b570a85 

Diff: https://git.reviewboard.kde.org/r/129280/diff/


Testing
-------

Autostart items can be edited and saved again from the systemsettings autostart KCM.


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161030/51e26279/attachment.html>


More information about the Kde-frameworks-devel mailing list