Review Request 129280: Fix editing autostart items

[Antonio Rojas]

> On Oct. 30, 2016, 10:20 a.m., David Faure wrote:
> > src/widgets/kpropertiesdialog.cpp, line 1242
> > <https://git.reviewboard.kde.org/r/129280/diff/1/?file=483165#file483165line1242>
> >
> >     But this returns the *parent* of base, right?
> >     
> >     I guess what we need here is rather QDir(base).canonicalPath(). Do you agree? Can you try that?

Ah yes. Actually I was wrong about canonicalFilePath, it works fine for directories. The problem was that it returns an empty string for non-existant dirs, which is usually the case for /usr/local/share/applications


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129280/#review100390
-----------------------------------------------------------


On Oct. 30, 2016, 10:36 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129280/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2016, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 371194
>     https://bugs.kde.org/show_bug.cgi?id=371194
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QFileInfo.canonicalFilePath() returns an empty string for non-existant directories, which matches any .desktop file path and makes KPropertiesDialog try to save it to the wrong location. Make sure that the dir exists before trying to match it in the .desktop file path.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp b570a85 
> 
> Diff: https://git.reviewboard.kde.org/r/129280/diff/
> 
> 
> Testing
> -------
> 
> Autostart items can be edited and saved again from the systemsettings autostart KCM.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161030/06a75d48/attachment.html>