Review Request 129280: Fix editing autostart items

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129280/#review100390
-----------------------------------------------------------




src/widgets/kpropertiesdialog.cpp (line 1242)
<https://git.reviewboard.kde.org/r/129280/#comment67374>

    But this returns the *parent* of base, right?
    
    I guess what we need here is rather QDir(base).canonicalPath(). Do you agree? Can you try that?


- David Faure


On Oct. 28, 2016, 6:02 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129280/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2016, 6:02 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 371194
>     https://bugs.kde.org/show_bug.cgi?id=371194
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QFileInfo.canonicalFilePath() returns an empty string for directories, QFileInfo.canonicalPath() should be used instead.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp b570a85 
> 
> Diff: https://git.reviewboard.kde.org/r/129280/diff/
> 
> 
> Testing
> -------
> 
> Autostart items can be edited and saved again from the systemsettings autostart KCM.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161030/12bff5b2/attachment.html>