[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

[shumski (Hrvoje Senjan)]

shumski added inline comments.

INLINE COMMENTS

> kossebau wrote in KDEInstallDirs.cmake:534
> Fear I am still missing what you mean. So let's go explicitely, here is what I understand to happen:
> 
> There are six different cases when using this macro and on the first invocation of cmake, from the combinations of installing to a different prefix or the same prefix as Qt (2 variants) versus KDE_INSTALL_USE_QT_SYS_PATHS being not set/defined, set to ON, set to OFF (3 variants).
> 
> In these 3 cases plugins, QCH & Co. will be all installed to Qt system dirs and thus automatically picked up by Qt, without the need for further env var settings:
> 
> - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, different prefix
> - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, same prefix
> - KDE_INSTALL_USE_QT_SYS_PATHS not passed as argument, same prefix (so
> 
> In the three other cases plugins, QCH & Co will be installed in dirs and need further env var settings, for Qt (and Qt Assistant) to also pick up the stuff.
> 
> Where do we see things differently? And just to make sure, you have seen the right lines at the link I passed before, how _default_KDE_INSTALL_USE_QT_SYS_PATHS is set to ON if the same prefix is used?

Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if CMAKE_INSTALL_PREFIX was /usr.

Ok, so the non-recognition part should not happen that often -> I'm assuming qch files are looked up as QLibraryInfo::DocumentationPath (so, QT_INSTALL_DOCS)  + *qch.

So with your path, they will not be found (yeah with different prefix they aren0t still found, but with qch/ subdir user needs one additional envar for KF5 qch's - imagine you need to export QT_PLUGIN_PATH for Qt plugins, and one more path for KF5 plugins).
I don't see a reason to append qch subdir to installation location -> as if you're intentionally hiding those files ;-)

REVISION DETAIL
  https://phabricator.kde.org/D2854

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, staniek, #frameworks
Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161130/4cf6806a/attachment.html>