Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

[Damjan Georgievski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129526/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 11:30 p.m.)


Review request for KDE Frameworks.


Changes
-------

set correct 'reviewers'


Bugs: 365722
    https://bugs.kde.org/show_bug.cgi?id=365722


Repository: kwallet-pam


Description
-------

Most recent Linux distributions setup a per-user XDG_RUNTIME_DIR as a tmpfs, which is also tied to their session lifecycle. Typically this is in /run/user/1000/.

My suggestion is to use $XDG_RUNTIME_DIR/kwallet5.socket if XDG_RUNTIME_DIR exists, or fallback to /tmp/kwallet5_${username}.socket if it doesn't.

Reproducible: Always


Diffs
-----

  pam_kwallet.c 809ab9a 

Diff: https://git.reviewboard.kde.org/r/129526/diff/


Testing
-------


Thanks,

Damjan Georgievski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161121/263fa146/attachment.html>