Review Request 126017: Provide debug output by default.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126017/#review88321
-----------------------------------------------------------


Fix it, then Ship it!





src/entry.cpp (line 25)
<https://git.reviewboard.kde.org/r/126017/#comment60568>

    there's a cmake macro to do this for you.


- David Edmundson


On Nov. 10, 2015, 8:57 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126017/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 8:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> The debug output is provided as categorized debug output and can be
> enabled/disabled simply by users using the QT_LOGGING_RULES environment
> variable. Hence, provide output by default and let the user optionally
> activate it.
> Also use a more descriptive name for the debug category by using the
> common reverse domain notation "org.kde.knewstuff".
> 
> 
> Diffs
> -----
> 
>   src/attica/atticaprovider.cpp 07508b05f324f25481bf05c5717c0ca60dce70d1 
>   src/entry.cpp 09f954267a5b71e2340f4e6ce9f6d311845aace5 
>   src/ui/itemsgridviewdelegate.cpp 9636ccf150f5db81863b7d16bf166b6623c77ff5 
>   src/ui/itemsviewbasedelegate.cpp e89068939c3c41ce281dbd4b628a218b022a3afb 
>   tests/khotnewstuff.cpp 2bfff35b136faf22bb41c92136f5bed96c1c9efe 
> 
> Diff: https://git.reviewboard.kde.org/r/126017/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160527/0dcd2ea3/attachment.html>