<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126017/">https://git.reviewboard.kde.org/r/126017/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126017/diff/1/?file=416097#file416097line25" style="color: black; font-weight: bold; text-decoration: underline;">src/entry.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">Q_LOGGING_CATEGORY</span><span class="p">(</span><span class="n">KNEWSTUFF</span><span class="p">,</span> <span class="s">"knewstuff"</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">Q_LOGGING_CATEGORY</span><span class="p">(</span><span class="n">KNEWSTUFF</span><span class="p">,</span> <span class="s">"<span class="hl">org.kde.</span>knewstuff"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there's a cmake macro to do this for you.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On November 10th, 2015, 8:57 p.m. UTC, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2015, 8:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The debug output is provided as categorized debug output and can be
enabled/disabled simply by users using the QT_LOGGING_RULES environment
variable. Hence, provide output by default and let the user optionally
activate it.
Also use a more descriptive name for the debug category by using the
common reverse domain notation "org.kde.knewstuff".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/attica/atticaprovider.cpp <span style="color: grey">(07508b05f324f25481bf05c5717c0ca60dce70d1)</span></li>
<li>src/entry.cpp <span style="color: grey">(09f954267a5b71e2340f4e6ce9f6d311845aace5)</span></li>
<li>src/ui/itemsgridviewdelegate.cpp <span style="color: grey">(9636ccf150f5db81863b7d16bf166b6623c77ff5)</span></li>
<li>src/ui/itemsviewbasedelegate.cpp <span style="color: grey">(e89068939c3c41ce281dbd4b628a218b022a3afb)</span></li>
<li>tests/khotnewstuff.cpp <span style="color: grey">(2bfff35b136faf22bb41c92136f5bed96c1c9efe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126017/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>