Review Request 127984: Always update the Trader parser from y/l sources

Pino Toscano pino at kde.org
Sat May 21 13:50:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127984/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kservice


Description
-------

Add Flex and Bison as required build dependencies, and use them to always regenerate at build time the Trader parser. This ensures that the parser does not rot, and there is no more need to rely on autogenerated sources added statically among the others.

Second commit: remove old generated files of Trader parser, and the helper regen.sh script.


Diffs
-----

  CMakeLists.txt 7f9d4f03510c66f230e5c189e92d90a31beb2cf2 
  src/CMakeLists.txt cdcf88532cb8d7aba0cf7fbd24086d7f5905b6da 
  src/services/lex.c c811f67fc89a1a1ad0aef0de2feeba00ebd5d057 
  src/services/regen.sh c2af52b92767ca2dd0d1abe19eb6cf50642b5096 
  src/services/yacc.h 070ffa4bc895683b4a5b7502a031679c7d70c74a 
  src/services/yacc.c 675650a8d787c5d7e66ef5e2cf97bdeb65660f4b 

Diff: https://git.reviewboard.kde.org/r/127984/diff/


Testing
-------

Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.


Thanks,

Pino Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160521/39077a61/attachment.html>


More information about the Kde-frameworks-devel mailing list