Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

[Stephen Kelly]

> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote:
> > Do you still have the sample application you made to test/verify this? I'd like to try it and it should probably be committed too.
> 
> Pino Toscano wrote:
>     No I don't :-/ I remember it was just removing indexes with associated widgets.

Maybe you could try to make it again. I'm not familiar with this code but I don't know any reason for adding this complexity.

I also don't consider myself the maintainer of this repo. I'm just commenting that it doesn't look right to me.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126610/#review94076
-----------------------------------------------------------


On March 28, 2016, 1:41 p.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126610/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 1:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Stephen Kelly.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> -------
> 
> When indexes are removed and their widgets deleted, the event filter on each widget is not removed, leading to the "you should not delete widgets manually"-alike warning.
> 
> Add an helper forgetAbout() function which performs all the actions done per-widget before deleting each, additionally removing also the event filter.
> 
> 
> Diffs
> -----
> 
>   src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 
>   src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 
>   src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126610/diff/
> 
> 
> Testing
> -------
> 
> A sample application with widgets for items in the model, removing indexes: no more warning at removal time.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160523/de863e15/attachment.html>