<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127984/">https://git.reviewboard.kde.org/r/127984/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Pino Toscano.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add Flex and Bison as required build dependencies, and use them to always regenerate at build time the Trader parser. This ensures that the parser does not rot, and there is no more need to rely on autogenerated sources added statically among the others.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Second commit: remove old generated files of Trader parser, and the helper regen.sh script.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine with flex 2.6.0 and bison 3.0.4; <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code> passes too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7f9d4f03510c66f230e5c189e92d90a31beb2cf2)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(cdcf88532cb8d7aba0cf7fbd24086d7f5905b6da)</span></li>
<li>src/services/lex.c <span style="color: grey">(c811f67fc89a1a1ad0aef0de2feeba00ebd5d057)</span></li>
<li>src/services/regen.sh <span style="color: grey">(c2af52b92767ca2dd0d1abe19eb6cf50642b5096)</span></li>
<li>src/services/yacc.h <span style="color: grey">(070ffa4bc895683b4a5b7502a031679c7d70c74a)</span></li>
<li>src/services/yacc.c <span style="color: grey">(675650a8d787c5d7e66ef5e2cf97bdeb65660f4b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127984/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>