Review Request 127887: Improve usage of Qt APIs
Jeremy Whiting
jpwhiting at kde.org
Thu May 12 16:05:08 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95428
-----------------------------------------------------------
The knewstuff (non moretools) side looks good to me.
- Jeremy Whiting
On May 11, 2016, 5:01 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 5:01 p.m.)
>
>
> Review request for KDE Frameworks and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Mostly clazy fixes, few cleanups
>
>
> Diffs
> -----
>
> src/core/installation.cpp 1887d0f
> src/kmoretools/kmoretools.h 32da22c
> src/kmoretools/kmoretools.cpp 8bd6751
> src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887
> src/kmoretools/kmoretoolsmenufactory.cpp aad3f00
> src/kmoretools/kmoretoolspresets.cpp 679e849
> src/staticxml/staticxmlprovider.cpp 541bf57
> src/ui/itemsviewdelegate.cpp 7001be2
> tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea
>
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
>
>
> Testing
> -------
>
> Builds, tests pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160512/d4c8dfe1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list