Review Request 127887: Improve usage of Qt APIs

Aleix Pol Gonzalez aleixpol at kde.org
Wed May 11 23:01:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/
-----------------------------------------------------------

(Updated May 12, 2016, 1:01 a.m.)


Review request for KDE Frameworks and Jeremy Whiting.


Changes
-------

Address most Kai issues.


Repository: knewstuff


Description
-------

Mostly clazy fixes, few cleanups


Diffs (updated)
-----

  src/core/installation.cpp 1887d0f 
  src/kmoretools/kmoretools.h 32da22c 
  src/kmoretools/kmoretools.cpp 8bd6751 
  src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 
  src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
  src/kmoretools/kmoretoolspresets.cpp 679e849 
  src/staticxml/staticxmlprovider.cpp 541bf57 
  src/ui/itemsviewdelegate.cpp 7001be2 
  tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 

Diff: https://git.reviewboard.kde.org/r/127887/diff/


Testing
-------

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160511/8a01edd1/attachment.html>


More information about the Kde-frameworks-devel mailing list