<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127887/">https://git.reviewboard.kde.org/r/127887/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The knewstuff (non moretools) side looks good to me.</p></pre>
<br />
<p>- Jeremy Whiting</p>
<br />
<p>On May 11th, 2016, 5:01 p.m. MDT, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated May 11, 2016, 5:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mostly clazy fixes, few cleanups</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/installation.cpp <span style="color: grey">(1887d0f)</span></li>
<li>src/kmoretools/kmoretools.h <span style="color: grey">(32da22c)</span></li>
<li>src/kmoretools/kmoretools.cpp <span style="color: grey">(8bd6751)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog_p.cpp <span style="color: grey">(466b887)</span></li>
<li>src/kmoretools/kmoretoolsmenufactory.cpp <span style="color: grey">(aad3f00)</span></li>
<li>src/kmoretools/kmoretoolspresets.cpp <span style="color: grey">(679e849)</span></li>
<li>src/staticxml/staticxmlprovider.cpp <span style="color: grey">(541bf57)</span></li>
<li>src/ui/itemsviewdelegate.cpp <span style="color: grey">(7001be2)</span></li>
<li>tests/kmoretools/kmoretoolstest_interactive.cpp <span style="color: grey">(b1cbdea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127887/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>