Review Request 127887: Improve usage of Qt APIs

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95365
-----------------------------------------------------------




src/core/installation.cpp (line 382)
<https://git.reviewboard.kde.org/r/127887/#comment64668>

    + QLatin1Char('/')



src/kmoretools/kmoretools.cpp (line 51)
<https://git.reviewboard.kde.org/r/127887/#comment64665>

    qDeleteAll?



src/kmoretools/kmoretoolsmenufactory.cpp (line 290)
<https://git.reviewboard.kde.org/r/127887/#comment64666>

    Range-for? groupingNames is const



src/kmoretools/kmoretoolspresets.cpp (lines 153 - 154)
<https://git.reviewboard.kde.org/r/127887/#comment64667>

    constFind


- Kai Uwe Broulik


On Mai 10, 2016, 1:37 nachm., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127887/
> -----------------------------------------------------------
> 
> (Updated Mai 10, 2016, 1:37 nachm.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Mostly clazy fixes, few cleanups
> 
> 
> Diffs
> -----
> 
>   src/core/installation.cpp 1887d0f 
>   src/kmoretools/kmoretools.cpp 8bd6751 
>   src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 
>   src/kmoretools/kmoretoolspresets.cpp 679e849 
>   src/staticxml/staticxmlprovider.cpp 541bf57 
>   src/ui/itemsviewdelegate.cpp 7001be2 
>   tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea 
> 
> Diff: https://git.reviewboard.kde.org/r/127887/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160510/98a2c978/attachment.html>