Review Request 127813: Process paths just once

[Aleix Pol Gonzalez]

> On May 2, 2016, 10:21 p.m., Albert Astals Cid wrote:
> > src/core/kconfiggroup.cpp, line 442
> > <https://git.reviewboard.kde.org/r/127813/diff/1/?file=462322#file462322line442>
> >
> >     Are we sure we want this to be static?

I'm not sure, my impression is that it's better if we only fetch this once, but I can easily be convinced otherwise.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/#review95112
-----------------------------------------------------------


On May 2, 2016, 6:32 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127813/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 6:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Just process every home path once, as the 3 alternatives will probably just be the same.
> Don't drop the file: prefix twice in every run.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfiggroup.cpp 39d2441 
> 
> Diff: https://git.reviewboard.kde.org/r/127813/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, apps work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160502/d4217f00/attachment.html>