Review Request 127813: Process paths just once

[Albert Astals Cid]

> On May 2, 2016, 8:21 p.m., Albert Astals Cid wrote:
> > src/core/kconfiggroup.cpp, line 442
> > <https://git.reviewboard.kde.org/r/127813/diff/1/?file=462322#file462322line442>
> >
> >     Are we sure we want this to be static?
> 
> Aleix Pol Gonzalez wrote:
>     I'm not sure, my impression is that it's better if we only fetch this once, but I can easily be convinced otherwise.

My rationale is that the old code adapted to the new values if they changed, if it doesn't really give us much having it static (which i think it's not a huge win) preserving the same behaviour looks like a good thing.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/#review95112
-----------------------------------------------------------


On May 2, 2016, 4:32 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127813/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 4:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Just process every home path once, as the 3 alternatives will probably just be the same.
> Don't drop the file: prefix twice in every run.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfiggroup.cpp 39d2441 
> 
> Diff: https://git.reviewboard.kde.org/r/127813/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, apps work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160504/e7b3447d/attachment.html>