Review Request 127813: Process paths just once
Albert Astals Cid
aacid at kde.org
Mon May 2 20:21:13 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/#review95112
-----------------------------------------------------------
src/core/kconfiggroup.cpp (line 439)
<https://git.reviewboard.kde.org/r/127813/#comment64555>
Are we sure we want this to be static?
- Albert Astals Cid
On May 2, 2016, 4:32 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127813/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 4:32 p.m.)
>
>
> Review request for KDE Frameworks and Matthew Dawson.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Just process every home path once, as the 3 alternatives will probably just be the same.
> Don't drop the file: prefix twice in every run.
>
>
> Diffs
> -----
>
> src/core/kconfiggroup.cpp 39d2441
>
> Diff: https://git.reviewboard.kde.org/r/127813/diff/
>
>
> Testing
> -------
>
> Tests pass, apps work.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160502/e0fa9299/attachment.html>
More information about the Kde-frameworks-devel
mailing list