Review Request 127383: Avoid introspecting a DBus interface when we don't use it.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127383/
-----------------------------------------------------------

(Updated March 20, 2016, 11:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 1cfa9e1bd60124886eb4dc74d4a83cf55f19902e by David Edmundson to branch master.


Repository: kdbusaddons


Description
-------

QDBusInterface is only useful if you want to know at runtime what methods a remote
interface has.

Using the generated interfaces skips the initial query to
.DBus.Introspect(). This makes everything 1 roundtrip faster.

Realistically it won't have any actual impact, but IMHO it's a bit cleaner


Diffs
-----

  src/CMakeLists.txt 6da110c405f348a1105870e7527e0b67646224ac 
  src/kdbusservice.cpp 30c485c9f52bcd361f29cc419b75c0c6215901eb 

Diff: https://git.reviewboard.kde.org/r/127383/diff/


Testing
-------

started kate twice, got a second windows with expected file
started konversation twice, first instance got reactivated.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160320/0ca8ded1/attachment.html>