Review Request 127383: Avoid introspecting a DBus interface when we don't use it.
David Faure
faure at kde.org
Sun Mar 20 09:36:33 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127383/#review93758
-----------------------------------------------------------
Ship it!
+ generating code ensures we use the methods defined in the dbus interface, very good move.
- David Faure
On March 16, 2016, 1:21 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127383/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 1:21 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdbusaddons
>
>
> Description
> -------
>
> QDBusInterface is only useful if you want to know at runtime what methods a remote
> interface has.
>
> Using the generated interfaces skips the initial query to
> .DBus.Introspect(). This makes everything 1 roundtrip faster.
>
> Realistically it won't have any actual impact, but IMHO it's a bit cleaner
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 6da110c405f348a1105870e7527e0b67646224ac
> src/kdbusservice.cpp 30c485c9f52bcd361f29cc419b75c0c6215901eb
>
> Diff: https://git.reviewboard.kde.org/r/127383/diff/
>
>
> Testing
> -------
>
> started kate twice, got a second windows with expected file
> started konversation twice, first instance got reactivated.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160320/e22d0c7d/attachment.html>
More information about the Kde-frameworks-devel
mailing list