Review Request 128312: Fix notify by taskbar

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128312/#review96957
-----------------------------------------------------------


Ship it!




Looks good!

- Martin Klapetek


On June 28, 2016, 11:52 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128312/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> For whatever reasons, the current implementation of notify by taskbar doesn't work locally. It also isn't implemented at all on e. g. OS X.
> 
> QApplication has a proper replacement that works on all platforms, so this simply switches to using that, and re-enables the notifybytaskbar on OS X.
> 
> 
> Diffs
> -----
> 
>   src/knotificationmanager.cpp 6f790b5 
>   src/notifybytaskbar.cpp 036d20a 
> 
> Diff: https://git.reviewboard.kde.org/r/128312/diff/
> 
> 
> Testing
> -------
> 
> Noticed notifications in the taskbar where there earlier were none.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160629/eda0bcb8/attachment.html>